Mario Limonciello <[email protected]> writes:

> Expose SSD130x contrast through the connector LUMINANCE property when
> DRM_LUMINANCE is enabled. Program contrast directly and retain the
> backlight class interface otherwise.
>
> Signed-off-by: Mario Limonciello <[email protected]>
> ---

Actually, one more comment:

>  
> -static const struct backlight_ops ssd130xfb_bl_ops[] = {
> +static const struct backlight_ops ssd130xfb_bl_ops[] __maybe_unused = {
>       [SSD130X_FAMILY] = {
>               .update_status  = ssd130x_update_bl,
>       },

I think that instead of __maybe_unused, this definition could also
be guarded by IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE).

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Reply via email to