AMD General

> -----Original Message-----
> From: Zhou1, Tao
> Sent: Saturday, October 10, 2026 10:14 AM
> To: Sun, Ce(Overlord) <[email protected]>; [email protected]
> Cc: Zhang, Hawking <[email protected]>; Chai, Thomas
> <[email protected]>; Yang, Stanley <[email protected]>
> Subject: RE: [PATCH] drm/amdgpu/ras: Use fw-managed EEPROM for MP1
> IP_VERSION(13,0,12)
>
>
>
> > -----Original Message-----
> > From: Sun, Ce(Overlord) <[email protected]>
> > Sent: Saturday, October 10, 2026 12:49 AM
> > To: [email protected]
> > Cc: Zhang, Hawking <[email protected]>; Chai, Thomas
> > <[email protected]>; Zhou1, Tao <[email protected]>; Yang, Stanley
> > <[email protected]>; Sun, Ce(Overlord) <[email protected]>
> > Subject: [PATCH] drm/amdgpu/ras: Use fw-managed EEPROM for MP1
> > IP_VERSION(13,0,12)
> >
> > For ASIC with MP1_HWIP IP_VERSION(13, 0, 12), enable firmware managed
> > EEPROM
> >
> > Signed-off-by: Ce Sun <[email protected]>
> > ---
> >  drivers/gpu/drm/amd/ras/core/ras_eeprom_mgr.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/ras/core/ras_eeprom_mgr.c
> > b/drivers/gpu/drm/amd/ras/core/ras_eeprom_mgr.c
> > index fe0e35357af1..cd332fc267be 100644
> > --- a/drivers/gpu/drm/amd/ras/core/ras_eeprom_mgr.c
> > +++ b/drivers/gpu/drm/amd/ras/core/ras_eeprom_mgr.c
> > @@ -40,11 +40,10 @@ static const struct ras_eeprom_ops
> > *ras_eeprom_mgr_get_ip_func(
> >     switch (ip_version) {
> >     case IP_VERSION(13, 0, 6):
> >     case IP_VERSION(13, 0, 14):
> > -   case IP_VERSION(13, 0, 12):
> > -   case IP_VERSION(13, 0, 15):
>
> [Tao] Why is IP_VERSION(13, 0, 15) affected as well?

[Tao] since there is no IP_VERSION(13, 0, 15) actually, then the patch is

Reviewed-by: Tao Zhou <[email protected]>

>
> >             mgr->eeprom_early_init_service_supported = false;
> >             return &ras_drv_eeprom_ops;
> >     case IP_VERSION(15, 0, 8):
> > +   case IP_VERSION(13, 0, 12):
> >             mgr->eeprom_early_init_service_supported = true;
> >             mgr->fw_record_enabled = true;
> >             return &ras_fw_eeprom_ops;
> > --
> > 2.34.1

Reply via email to