On Tue, Oct 13, 2026 at 7:11 PM Deucher, Alexander <[email protected]> wrote: > > Public > > > -----Original Message----- > > From: amd-gfx <[email protected]> On Behalf Of Victor > > Skvortsov > > Sent: Tuesday, October 13, 2026 6:30 PM > > To: [email protected]; Lazar, Lijo <[email protected]>; Luo, > > Zhigang <[email protected]>; Wan, Gavin <[email protected]> > > Cc: Skvortsov, Victor <[email protected]> > > Subject: [PATCH] drm/amdgpu: Enable queue reset for sdma 7.1 VFs > > > > VFs support same SDMA 7.1 queue reset capabilities as baremetal. > > > > This goes through the MMIO path for kernel SDMA queues. Assuming that is ok > for VFs,
I had a chat with Victor and even though the MMIO parameter passed to the reset helper is set to true for sdma 7.1, the actual queue reset code for mes 12.1 never uses MMIO so it should be safe. @Victor Skvortsov Please fix the caller to pass false. With that fixed, feel free to add my RB. Alex > Reviewed-by: Alex Deucher <[email protected]> > > > > Signed-off-by: Victor Skvortsov <[email protected]> > > --- > > drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c > > b/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c > > index 21882f2cd2ae..6bea65622086 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c > > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v7_1.c > > @@ -1333,8 +1333,7 @@ static int sdma_v7_1_sw_init(struct > > amdgpu_ip_block *ip_block) > > > > adev->sdma.supported_reset = > > amdgpu_get_soft_full_reset_mask(&adev- > > >sdma.instance[0].ring); > > - if (!amdgpu_sriov_vf(adev) && > > - !adev->debug_disable_gpu_ring_reset) > > + if (!adev->debug_disable_gpu_ring_reset) > > adev->sdma.supported_reset |= > > AMDGPU_RESET_TYPE_PER_QUEUE; > > > > r = amdgpu_sdma_sysfs_reset_mask_init(adev); > > -- > > 2.34.1 >
