Tested on Navi 31 (DCN3.2) the same way as v2: a kernel built from
mainline 65ba8f34ec88 (7.4 merge window), with and without this patch,
opening crtc-0/crc/data for the first time after boot.
without: two WARNs from dc_helper.c:53 in set_reg_field_values(),
both reached from optc1_configure_crc() under
crtc_crc_open()
with: no WARN, and CRC capture on engine 0 works as before
I also checked the generations I cannot test. I expanded the OPTC
register and mask lists of every DCN3.0 and later resource with the
preprocessor against that ASIC's own offset and sh_mask headers,
before and after the patch. Every register and field the patch adds
is defined for each ASIC and each OTG instance it is used with, no
initializer gains a duplicate entry, and DCN3.5, 3.5.1 and 3.6 end up
with the same entries as before. The patch also applies cleanly to
v7.3.
You are right about DCN2.x: their lists start with
TG_COMMON_REG_LIST_DCN and TG_COMMON_MASK_SH_LIST_DCN, which already
have the engine 1 entries. My note in v2 that they were missing was
wrong.
A nit: checkpatch wants a Closes: or Link: right after Reported-by.
The bug was reported in v2 of my patch, so a Link: to it would do:
Link:
https://lore.kernel.org/all/[email protected]/
Reviewed-by: Mikhail Gavrilov <[email protected]>
Tested-by: Mikhail Gavrilov <[email protected]> # Navi 31 (DCN3.2)
--
Thanks,
Mikhail
