On Wed, Nov 11, 2026 at 4:35 AM Thomas Zimmermann <[email protected]> wrote: > > Hi > > Am 10.11.26 um 22:49 schrieb Alex Deucher: > > On Tue, Nov 10, 2026 at 7:11 AM Thomas Zimmermann <[email protected]> > > wrote: > >> The helper drm_crtc_init() sets up a CRTC with a primary plane for > >> non-atomic mode setting. Only drivers for some AMD hardware still > >> use it. > >> > >> Inline drm_crtc_init() into amdgpu and radeon and remove it from > >> DRM. All new code implements atomic mode setting, which does not > >> use drm_crtc_init(). > >> > > I'd like to drop all of the old amdgpu non-DC code since DC is now the > > default, and we have an LTS kernel now. I'm planning to send these > > out in the near future: > > https://gitlab.freedesktop.org/agd5f/linux/-/commits/remove-non-dc-display?ref_type=heads > > That's even better. :) Do you have an ETA for this work? Resolving > drm_crtc_init() is required for that series I referred to at [1].
Just sent them out. Thanks, Alex > > > > So that just leaves radeon. > > I'll fix the Sashiko report and send this out in a separate patch. > > Best regards > Thomas > > > > > Alex > > > >> DRM support for kernel panic is only implemented in amdgpu. Take > >> the panic helpers from drm_crtc_init() in amdgpu, but clean it up > >> in radeon. > >> > >> With this series in place, DRM's helpers for drawing panic screens > >> can be further integrated with other drawing helpers, as outlined > >> in [1]. > >> > >> Tested on radeon with a Radeon HD 6570. > >> > >> [1] > >> https://lore.kernel.org/dri-devel/[email protected]/ > >> > >> Thomas Zimmermann (5): > >> drm/amdgpu: dce_v6_0: Inline drm_crtc_init() > >> drm/amdgpu: dce_v8_0: Inline drm_crtc_init() > >> drm/amdgpu: dce_v10_0: Inline drm_crtc_init() > >> drm/radeon: Inline drm_crtc_init() > >> drm: Remove drm_crtc_init() > >> > >> drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 44 ++++++++++++++- > >> drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 44 ++++++++++++++- > >> drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 44 ++++++++++++++- > >> drivers/gpu/drm/drm_crtc.c | 26 +++------ > >> drivers/gpu/drm/drm_modeset_helper.c | 74 ------------------------- > >> drivers/gpu/drm/radeon/radeon_display.c | 47 +++++++++++++--- > >> include/drm/drm_modeset_helper.h | 3 - > >> include/drm/drm_plane.h | 5 -- > >> 8 files changed, 170 insertions(+), 117 deletions(-) > >> > >> -- > >> 2.56.0 > >> > > -- > -- > Thomas Zimmermann > Graphics Driver Developer > SUSE Software Solutions Germany GmbH > Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com > GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg) > >
