Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/amd/display: dc_dmcu_is_initialized() duplicates dc_is_dmcu_initialized() --
commit 73f1ba49a5d9e363674e88529801b1a9200d901c Author: Dave Airlie <[email protected]> drm/amd/display: Add DC primitives for ABM hardware programming This commit adds DC-side hardware primitives for DMCU iRAM loading and ABM configuration and event programming so that modules/power and amdgpu_dm no longer access struct resource_pool directly. > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_abm.c > b/drivers/gpu/drm/amd/display/dc/core/dc_abm.c > new file mode 100644 > index 0000000000000..1ed4b5fb6f937 > --- /dev/null > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_abm.c > @@ -0,0 +1,121 @@ [ ... ] > +bool dc_dmcu_is_initialized(struct dc *dc) > +{ > + if (!dc->res_pool || !dc->res_pool->dmcu) > + return false; > + > + return dc->res_pool->dmcu->funcs->is_dmcu_initialized( > + dc->res_pool->dmcu); > +} [Severity: Low] Does dc_dmcu_is_initialized() duplicate the existing dc_is_dmcu_initialized() helper? drivers/gpu/drm/amd/display/dc/core/dc.c:dc_is_dmcu_initialized() { struct dmcu *dmcu = dc->res_pool->dmcu; if (dmcu) return dmcu->funcs->is_dmcu_initialized(dmcu); return false; } dc_is_dmcu_initialized() is already declared in dc.h and has no other callers in the tree, so these two public helpers could be consolidated. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=16
