Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] drm: build failure in amdgpu DCE files after removing drm_crtc_init() --
commit aafe7374dc79cd31dda721134581ac1246ab8089 Author: Thomas Zimmermann <[email protected]> drm: Remove drm_crtc_init() This commit removes the legacy drm_crtc_init() helper, its default primary plane structures, and the format_default flag from struct drm_plane. > diff --git a/include/drm/drm_modeset_helper.h > b/include/drm/drm_modeset_helper.h > index 7e3d4c5a7f66d..6b9421aee5360 100644 > --- a/include/drm/drm_modeset_helper.h > +++ b/include/drm/drm_modeset_helper.h > @@ -37,9 +37,6 @@ void drm_helper_mode_fill_fb_struct(struct drm_device *dev, > const struct drm_format_info *info, > const struct drm_mode_fb_cmd2 *mode_cmd); > > -int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, > - const struct drm_crtc_funcs *funcs); > - > int drm_mode_config_helper_suspend(struct drm_device *dev); > int drm_mode_config_helper_resume(struct drm_device *dev); > [Severity: High] Does removing drm_crtc_init() break the build when CONFIG_DRM_AMDGPU is enabled? dce_v10_0_crtc_init() in drivers/gpu/drm/amd/amdgpu/dce_v10_0.c (as well as dce_v8_0_crtc_init() and dce_v6_0_crtc_init()) still calls drm_crtc_init(): drivers/gpu/drm/amd/amdgpu/dce_v10_0.c:dce_v10_0_crtc_init() { ... drm_crtc_init(adev_to_drm(adev), &amdgpu_crtc->base, &dce_v10_0_crtc_funcs); drm_mode_crtc_set_gamma_size(&amdgpu_crtc->base, 256); ... } Building amdgpu therefore fails with an implicit declaration of drm_crtc_init(). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
