On 11/12/2026 07:43, Kent Russell wrote:

Just minor comments on these. Otherwise the series is:

Reviewed-by: Jay Cornwall <[email protected]>

+                       dev_err(adev->dev, "failed to clear GPR on xcc %d\n", 
xcc_id);
+                       goto pro_end;
+               }
+
+               /* wait for the GPU to finish processing the IB */
+               r = dma_fence_wait(fence, false);
+               if (r)
+                       dev_err(adev->dev, "timeout to clear GPR on xcc %d\n", 
xcc_id);
pro_end:
-       if (fence)
-               dma_fence_put(fence);
-       amdgpu_ib_free(&wb_ib, NULL);
+               if (fence) {
+                       dma_fence_put(fence);
+                       fence = NULL;
+               }
+               amdgpu_ib_free(&wb_ib, NULL);
+
+               if (r)
+                       break;
+       }
if (r)
                dev_dbg(adev->dev, "Clean GPR Failed\n");

This logic is not clearing GPRs. It's clearing residual fault state left due to a design defect. The error messages could be clearer.

Reply via email to