AMD General

Hi @Sun, Ce(Overlord)<mailto:[email protected]>

I'm concerned about the current amdgpu_uniras_query_block_ecc implementation. 
RAS_CMD__GET_BLOCK_ECC_STATUS is an SR-IOV VF-specific RAS command and should 
not be invoked in the current UniRAS code path. Using it in a bare-metal 
environment would trigger an unsupported RAS command error and could cause GPU 
reset to fail.

Could we evaluate updating amdgpu_persistent_edc_harvesting_supported to 
prevent inappropriate calls to amdgpu_uniras_query_block_ecc? We should also 
consider adding an explicit check to ensure that amdgpu_uniras_query_block_ecc 
is called only for SR-IOV VFs, or retiring the function if it is no longer 
needed.

Regards,
Hawking

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Ce Sun
Sent: Friday, November 13, 2026 11:28 AM
To: [email protected]
Cc: Zhang, Hawking <[email protected]>; Zhou1, Tao <[email protected]>; 
Sun, Ce(Overlord) <[email protected]>; Chai, Thomas <[email protected]>
Subject: [PATCH] drm/amdgpu: skip uniras block ECC query in GPU reset path

amdgpu_uniras_query_block_ecc doesn't support being called during GPU reset.

Signed-off-by: Ce Sun <[email protected]<mailto:[email protected]>>
Signed-off-by: YiPeng Chai <[email protected]<mailto:[email protected]>>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 08c6e55a7927..7be33d5559ab 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -3770,6 +3770,10 @@ static int amdgpu_persistent_edc_harvesting(struct 
amdgpu_device *adev,
        if (!amdgpu_persistent_edc_harvesting_supported(adev))
                return 0;

+       if ((amdgpu_in_reset(adev) || amdgpu_ras_in_recovery(adev)) &&
+            amdgpu_uniras_enabled(adev))
+               return 0;
+
        if (amdgpu_ras_query_error_status(adev, &info) != 0)
                drm_warn(adev_to_drm(adev), "RAS init query failure");

--
2.34.1

Reply via email to