Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] platform/x86: apple-gmux: missing Fixes trailer for commit 0c18184de990 --
commit b19f0c98a4551005b56d57291e3256d29b977707 Author: Atharva Tiwari <[email protected]> > platform/apple-gmux: Fix MMIO interface > > This patch brings a lot of fixes to MMIO interface such as: > 1. Using 1ms waits instead of 100us. > 2. Checking if Timed out before reading and writing > 3. Adding missing wait before gmux_mmio_write32 > > Tested-by: Sebastian Zygadlo <[email protected]> > Tested-by: Yossef Osman <[email protected]> > Co-developed-by: Andre Eikmeyer <[email protected]> > Signed-off-by: Andre Eikmeyer <[email protected]> > Signed-off-by: Atharva Tiwari <[email protected]> [Severity: Low] This fixes the Apple T2 MMIO gmux wait logic, timeout checks, and the missing pre-write wait in gmux_mmio_write32(). Should this include: Fixes: 0c18184de990 ("platform/x86: apple-gmux: support MMIO gmux on T2 Macs") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
