> I don't see the corresponding addition of adding the cpu_device_id.h.
> The commit message doesn't mention that. Am I missing something here?

The #include <asm/cpu_device_id.h> line is unchanged; only the #if/#endif
and the redundant <asm/intel-family.h> include are removed.

Thanks,
Pavel

> -----Original Message-----
> From: Logan Gunthorpe <[email protected]>
> Sent: Thursday, November 12, 2026 9:18 PM
> To: Popov, Pavel E <[email protected]>; Rafael J. Wysocki
> <[email protected]>; Viresh Kumar <[email protected]>; Jani Nikula
> <[email protected]>; Joonas Lahtinen
> <[email protected]>; Vivi, Rodrigo <[email protected]>;
> Tvrtko Ursulin <[email protected]>; Alex Deucher
> <[email protected]>; Christian König
> <[email protected]>; Hans de Goede <[email protected]>; Ilpo
> Järvinen <[email protected]>; Peter Huewe
> <[email protected]>; Jarkko Sakkinen <[email protected]>; Tom Lendacky
> <[email protected]>; Herbert Xu <[email protected]>
> Cc: Leon Romanovsky <[email protected]>; Bjorn Helgaas
> <[email protected]>; Arnd Bergmann <[email protected]>; Len Brown
> <[email protected]>; Sakari Ailus <[email protected]>; Jason
> Gunthorpe <[email protected]>; David Airlie <[email protected]>; Simona Vetter
> <[email protected]>; David S . Miller <[email protected]>;
> [email protected]; [email protected]; [email protected]; intel-
> [email protected]; [email protected]; dri-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]; [email protected]
> Subject: Re: [PATCH 3/7] drm/amdgpu: Include <asm/cpu_device_id.h>
> unconditionally
> 
> 
> 
> On 2026-11-11 5:48 p.m., Pavel Popov wrote:
> > <asm/cpu_device_id.h> now has a generic version, so the #ifdef
> > CONFIG_X86 around the include is no longer needed.
> >
> > <asm/intel-family.h> is included by <asm/cpu_device_id.h>.
> >
> > Signed-off-by: Pavel Popov <[email protected]>
> > ---
> > Depends on <asm-generic/cpu_device_id.h> from [1]; please apply after
> > it is in mainline.
> >
> > [1]
> > https://lore.kernel.org/r/20261111234439.4098-1-
> [email protected]
> > m
> >
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index 19a566187df..fc4e7273630 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -88,10 +88,7 @@
> >
> >  #include <drm/drm_drv.h>
> >
> > -#if IS_ENABLED(CONFIG_X86)
> > -#include <asm/intel-family.h>
> >  #include <asm/cpu_device_id.h>
> > -#endif
> >
> I don't see the corresponding addition of adding the cpu_device_id.h.
> The commit message doesn't mention that. Am I missing something here?
> 
> Logan

Reply via email to