> On 11/13/2026 9:07 PM WET [email protected] wrote:
> [Severity: Medium]
> Can a connector-only abm_level commit on a VRR-active CRTC drop active
> overlay planes from DC?

I think his is real. Before this patch, connectors_changed forced 
a modeset, and the modeset added every plane on the CRTC. Without 
it, an ABM-only commit on a CRTC with VRR active carries only the 
primary plane that amdgpu_dm_crtc_helper_atomic_check() pulls in, 
and DC's full update drops an active overlay until the next flip. 
The -EINVAL doesn't happen, since DM's private context still holds 
the overlay

v3 adds the CRTC's planes when the level changes, similar to how
amdgpu_dm_atomic_check() already does for color management and VRR
changes:

                if (dm_old_con_state->abm_level != dm_new_con_state->abm_level) 
{
                        ret = drm_atomic_add_affected_planes(state, 
new_con_state->crtc);
                        if (ret) {
                                drm_dbg_atomic(dev,
                                               
"drm_atomic_add_affected_planes() failed: %pe\n",
                                               ERR_PTR(ret));
                                goto fail;
                        }
                }

I'll wait a bit longer for other feedback on v2 before sending v3

Hugo

Reply via email to