AMD General

Hi Christian,

Please see the attached patch. Is this what do you mean?

Thanks,
Tharshan

-----Original Message-----
From: Limonciello, Mario <[email protected]>
Sent: Monday, November 16, 2026 2:44 PM
To: Koenig, Christian <[email protected]>; Thothiralingam, Logatharshan 
<[email protected]>; [email protected]
Cc: Deucher, Alexander <[email protected]>; Perez, Randy 
<[email protected]>; Chiu, Michael <[email protected]>; Prosyak, Vitaly 
<[email protected]>
Subject: Re: drm/amdgpu: Patch review for gfx hang on submitted jobs for S3



On 11/16/26 13:42, Christian König wrote:
> On 11/16/26 16:24, Mario Limonciello wrote:
>> On 11/16/26 09:04, Christian König wrote:
>>> Hi Tharshan,
>>>
>>> the idea looks good in general, but could be simplified a bit by waiting 
>>> for the VM to be idle.
>>>
>>> Question is why don't we already have that? Or do we already have that 
>>> somewhere else? I'm pretty sure that waiting for all submissions before S3 
>>> should already been implemented somewhere.
>>>
>>> Adding Mario to answer that question, he has been working on suspend/resume 
>>> quite a lot recently.
>>
>> I thought we had something like this, but looking through the code base it 
>> seems not (or I missed it).
>>
>> I think it's the wrong kind of patch though.  I believe we should use some 
>> of the existing flush functions and do it at the same time that we evict 
>> resources.  Something like this (attached).
>
> Please drop the timeout, keep in mind that we should always wait forever for 
> dma_fences.
>
> Apart from that looks reasonable to me, Christian.

OK, I'll post it on it's own thread and drop the timeout.

>
>>
>> Can you see if this also helps?
>>
>>>
>>> Adding Vitaly to double check if we have already a test case for that.
>>>
>>> Thanks,
>>> Christian.
>>>
>>> On 11/13/26 17:44, Thothiralingam, Logatharshan wrote:
>>>> AMD General
>>>>
>>>>
>>>> Hi,
>>>>
>>>>
>>>> Please help me review the attached patch.
>>>>
>>>>
>>>> A gfx hang that occurs 2 out of 400 times when performing S3 cycles. The 
>>>> issue is seen with the kernel version 6.18.8 and on AMD hardware; Picasso 
>>>> gfx9 APU.
>>>>
>>>>
>>>> When going to S3 suspend, the driver checks whether GPU has completed its 
>>>> tasks, but it doesn’t wait for jobs that are submitted to the scheduler. 
>>>> As a result, queued up jobs slip into the ring and are lost when WPTR is 
>>>> set to 0. On wake up, we hit a timeout followed by a hang.
>>>>
>>>>
>>>> The fix is to wait for all scheduled task to finish before going to S3. I 
>>>> tested the patch and the issue is not seen again.
>>>>
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Tharshan
>>>>
>>>
>

Attachment: 0001-drm-amdgpu-drain-queued-user-submissions-before-suspend_6.18.38.patch
Description: 0001-drm-amdgpu-drain-queued-user-submissions-before-suspend_6.18.38.patch

Reply via email to