Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/sched: contradictory sched_list kernel-doc in drm_sched_entity_init() --
commit 51236e2b589e5bb2f95788276a6d8bea43b26e11 Author: Tvrtko Ursulin <[email protected]> drm/sched: Remove the single scheduler special case This commit stores a single scheduler pointer directly in a union with sched_list in struct drm_sched_entity so that entities with a single scheduler retain their scheduler reference for runtime priority changes. > diff --git a/drivers/gpu/drm/scheduler/sched_entity.c > b/drivers/gpu/drm/scheduler/sched_entity.c > index a18f637f9e998..6ff455373067f 100644 > --- a/drivers/gpu/drm/scheduler/sched_entity.c > +++ b/drivers/gpu/drm/scheduler/sched_entity.c > @@ -102,7 +102,9 @@ ktime_t drm_sched_entity_stats_job_add_gpu_time(struct > drm_sched_job *job) > * @guilty: atomic_t set to 1 when a job on this queue > * is found to be guilty causing a timeout > * > - * Note that the &sched_list must have at least one element to schedule the > entity. > + * Note that the &sched_list must have exactly one element to schedule the > + * entity. Callers which pass more than one scheduler on the @sched_list must > + * ensure the list remains valid for the lifetime of the entity. [Severity: Low] Should this still say "at least one element" rather than "exactly one element"? drm_sched_entity_init() accepts one or more schedulers in sched_list, as described in the following sentence. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
