Am 19.01.2018 um 11:14 schrieb Emily Deng:
It still has some serious issues(guest driver reload fail, etc),
when use pollmem feature for sdma3.

Signed-off-by: Emily Deng <[email protected]>
---
  drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c 
b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
index 3e22ae4..0f8f614 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
@@ -1209,7 +1209,7 @@ static int sdma_v3_0_sw_init(void *handle)
        for (i = 0; i < adev->sdma.num_instances; i++) {
                ring = &adev->sdma.instance[i].ring;
                ring->ring_obj = NULL;
-               if (!amdgpu_sriov_vf(adev)) {
+               if (1) {

That needs a comment why we have it and I suggest writing this as:

/* Disabled for now because... */
if (true /* !amdgpu_sriov_vf(adev) */)

Regards,
Christian.

                        ring->use_doorbell = true;
                        ring->doorbell_index = (i == 0) ?
                                AMDGPU_DOORBELL_sDMA_ENGINE0 : 
AMDGPU_DOORBELL_sDMA_ENGINE1;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to