On Tue, Mar 6, 2018 at 5:10 AM, Rex Zhu <rex....@amd.com> wrote:
> Powerplay is for the hw ip smu, for RV, smu10 is used,
> so use smu10 as the prefix of the files name.
>
> Change-Id: Icf9c8a9d4b5deccd4fbfb9ecfab443db79934c77
> Signed-off-by: Rex Zhu <rex....@amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/Makefile       |    2 +-
>  drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c     | 1075 -------------------
>  drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h     |  322 ------
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c  | 1076 
> ++++++++++++++++++++
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.h  |  322 ++++++
>  drivers/gpu/drm/amd/powerplay/smumgr/Makefile      |    2 +-
>  drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c   |  399 --------
>  drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h   |   61 --
>  .../gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c    |  399 ++++++++
>  .../gpu/drm/amd/powerplay/smumgr/smu10_smumgr.h    |   61 ++
>  10 files changed, 1860 insertions(+), 1859 deletions(-)
>  delete mode 100644 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
>  delete mode 100644 drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.h
>  create mode 100644 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
>  create mode 100644 drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.h
>  delete mode 100644 drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c
>  delete mode 100644 drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h
>  create mode 100644 drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c
>  create mode 100644 drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.h


I'm ok with patches 1-3, although I think we should work on renaming
the functions eventually too to match the file names.  For patch 4, I
think we should stick with the asic names.  The smu7 variants are too
confusing.  I can't remember if CI was 7.0.1 or 7.0.2, etc.  I'd
prefer to align the file names to the smu interface headers (e.g.,
smu7, smu71, smu72, smu73, smu74).  BTW, did you use git mv to
generate these patches?

Alex
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to