On 2018-06-22 12:34 PM, Christian König wrote: > Am 22.06.2018 um 11:10 schrieb Michel Dänzer: >> From: Michel Dänzer <[email protected]> >> >> start / last / max_entries are numbers of GPU pages, pfn / count are >> numbers of CPU pages. Convert between them accordingly. >> >> Fixes badness on systems with > 4K page size. >> >> Cc: [email protected] >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106258 >> Reported-by: Matt Corallo <[email protected]> >> Tested-by: [email protected] >> Signed-off-by: Michel Dänzer <[email protected]> > > Nice work!
Thanks. > Just one comment: Can we somewhere add a define for > "(PAGE_SIZE / AMDGPU_GPU_PAGE_SIZE)"? > > IIRC that term was used in the GART code as well and just adding it > somewhere could makes things cleaner if you ask me. Sure, but that can be a follow-up patch, right? Can I get your R-b for this one? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
