Am 24.01.19 um 13:06 schrieb Ard Biesheuvel: > The DRM driver stack is designed to work with cache coherent devices > only, but permits an optimization to be enabled in some cases, where > for some buffers, both the CPU and the GPU use uncached mappings, > removing the need for DMA snooping and allocation in the CPU caches. > > The use of uncached GPU mappings relies on the correct implementation > of the PCIe NoSnoop TLP attribute by the platform, otherwise the GPU > will use cached mappings nonetheless. On x86 platforms, this does not > seem to matter, as uncached CPU mappings will snoop the caches in any > case. However, on ARM and arm64, enabling this optimization on a > platform where NoSnoop is ignored results in loss of coherency, which > breaks correct operation of the device. Since we have no way of > detecting whether NoSnoop works or not, just disable this > optimization entirely for ARM and arm64. > > Cc: Christian Koenig <christian.koe...@amd.com> > Cc: Alex Deucher <alexander.deuc...@amd.com> > Cc: David Zhou <david1.z...@amd.com> > Cc: Huang Rui <ray.hu...@amd.com> > Cc: Junwei Zhang <jerry.zh...@amd.com> > Cc: Michel Daenzer <michel.daen...@amd.com> > Cc: David Airlie <airl...@linux.ie> > Cc: Daniel Vetter <dan...@ffwll.ch> > Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> > Cc: Maxime Ripard <maxime.rip...@bootlin.com> > Cc: Sean Paul <s...@poorly.run> > Cc: Michael Ellerman <m...@ellerman.id.au> > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Cc: Will Deacon <will.dea...@arm.com> > Cc: Christoph Hellwig <h...@infradead.org> > Cc: Robin Murphy <robin.mur...@arm.com> > Cc: amd-gfx list <amd-gfx@lists.freedesktop.org> > Cc: dri-devel <dri-de...@lists.freedesktop.org> > Reported-by: Carsten Haitzler <carsten.haitz...@arm.com> > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
The subject line should probably read "disable uncached...". With that fixed the patch is Reviewed-by: Christian König <christian.koe...@amd.com>. Regards, Christian. > --- > include/drm/drm_cache.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/include/drm/drm_cache.h b/include/drm/drm_cache.h > index bfe1639df02d..97fc498dc767 100644 > --- a/include/drm/drm_cache.h > +++ b/include/drm/drm_cache.h > @@ -47,6 +47,24 @@ static inline bool drm_arch_can_wc_memory(void) > return false; > #elif defined(CONFIG_MIPS) && defined(CONFIG_CPU_LOONGSON3) > return false; > +#elif defined(CONFIG_ARM) || defined(CONFIG_ARM64) > + /* > + * The DRM driver stack is designed to work with cache coherent devices > + * only, but permits an optimization to be enabled in some cases, where > + * for some buffers, both the CPU and the GPU use uncached mappings, > + * removing the need for DMA snooping and allocation in the CPU caches. > + * > + * The use of uncached GPU mappings relies on the correct implementation > + * of the PCIe NoSnoop TLP attribute by the platform, otherwise the GPU > + * will use cached mappings nonetheless. On x86 platforms, this does not > + * seem to matter, as uncached CPU mappings will snoop the caches in any > + * case. However, on ARM and arm64, enabling this optimization on a > + * platform where NoSnoop is ignored results in loss of coherency, which > + * breaks correct operation of the device. Since we have no way of > + * detecting whether NoSnoop works or not, just disable this > + * optimization entirely for ARM and arm64. > + */ > + return false; > #else > return true; > #endif _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
