Am 29.01.19 um 22:54 schrieb Marek Olšák:
On Tue, Jan 29, 2019 at 3:01 AM Christian König
<ckoenig.leichtzumer...@gmail.com
<mailto:ckoenig.leichtzumer...@gmail.com>> wrote:
Am 28.01.19 um 22:52 schrieb Marek Olšák:
> From: Marek Olšák <marek.ol...@amd.com <mailto:marek.ol...@amd.com>>
>
> Normal syncobjs signal when an IB finishes. Start syncobjs
signal when
> an IB starts.
That approach has quite a number of problems (for example you can't
allocate memory at this point).
Even if I drop this patch, can you describe all the problems with it?
Andrey and I would like to understand this.
amdgpu_mn_lock(p->mn);
...
r = drm_syncobj_create(&syncobj, 0,...
You can't allocate memory while holding the MN lock, so calling
drm_syncobj_create() here is forbidden.
r = drm_syncobj_get_handle(p->filp, syncobj,...
This can fail which would result in a syncobj which is never signaled
nor freed.
Regards,
Christian.
Thanks,
Marek
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
