Ping? Alex
On Mon, Feb 18, 2019 at 5:35 PM Alex Deucher <[email protected]> wrote: > > This was noticed by Gustavo and his -Wimplicit-fallthrough > patches. However, in this case, I believe we should have breaks > rather than falling though, that said, in practice we should > never fall through in the first place so there should be no > change in behavior. > > Signed-off-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c > b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c > index 52abca065764..2d4cfe14f72e 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c > @@ -2330,6 +2330,7 @@ static uint32_t polaris10_get_offsetof(uint32_t type, > uint32_t member) > case DRAM_LOG_BUFF_SIZE: > return offsetof(SMU74_SoftRegisters, > DRAM_LOG_BUFF_SIZE); > } > + break; > case SMU_Discrete_DpmTable: > switch (member) { > case UvdBootLevel: > @@ -2339,6 +2340,7 @@ static uint32_t polaris10_get_offsetof(uint32_t type, > uint32_t member) > case LowSclkInterruptThreshold: > return offsetof(SMU74_Discrete_DpmTable, > LowSclkInterruptThreshold); > } > + break; > } > pr_warn("can't get the offset of type %x member %x\n", type, member); > return 0; > -- > 2.20.1 > _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
