> -----Original Message----- > From: Dan Carpenter [mailto:[email protected]] > Sent: Thursday, March 21, 2019 2:28 PM > To: Deucher, Alexander <[email protected]>; Wang, Kevin(Yang) > <[email protected]> > Cc: Koenig, Christian <[email protected]>; Zhou, David(ChunMing) > <[email protected]>; David Airlie <[email protected]>; Daniel Vetter > <[email protected]>; Huang, Ray <[email protected]>; Gao, Likun > <[email protected]>; Gui, Jack <[email protected]>; amd- > [email protected]; [email protected] > Subject: [PATCH] drm/amd/powerplay: Fix double unlock bug in > smu_sys_set_pp_table() > > We already unlocked a few lines earlier so this code unlocks twice on the > success path. > > Fixes: 5809d7420f97 ("drm/amd/powerplay: implement sysfs of pp_table for > smu11 (v2)") > Signed-off-by: Dan Carpenter <[email protected]>
Nice catch! Thanks, Dan. Kevin, could you please verify this patch. Reviewed-by: Huang Rui <[email protected]> > --- > I'm not sure what this bug looks like at runtime, but it's slightly weird > that no > one noticed. This is from static analysis and I haven't tested it myself. > > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index 00b7c885772b..7e8c74da6a74 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -187,6 +187,8 @@ int smu_sys_set_pp_table(struct smu_context *smu, > void *buf, size_t size) > if (ret) > pr_info("smu reset failed, ret = %d\n", ret); > > + return ret; > + > failed: > mutex_unlock(&smu->mutex); > return ret; > -- > 2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
