Maybe mention that this fixes issues with stutter mode and 4k.  With that,
Acked-by: Alex Deucher <alexander.deuc...@amd.com>
________________________________
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of hersen wu 
<hersenxs...@amd.com>
Sent: Monday, April 15, 2019 9:52 AM
To: amd-gfx@lists.freedesktop.org; Feng, Kenneth
Cc: Wu, Hersen
Subject: [PATCH] SWDEV-183622 4k@60hz dp monitor always flicking

[WHY] clock unit mis-match between caller DC and SMU interface.
      dc pass lock in mhz. the same unit as smu. no covert is needed.

[HOW] remove covert_10k_to_mhz in smu interface

Signed-off-by: hersen wu <hersenxs...@amd.com>
---
 .../gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c   | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c 
b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
index f32e3d0aaea6..078613348e78 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c
@@ -204,18 +204,13 @@ static int smu10_set_clock_limit(struct pp_hwmgr *hwmgr, 
const void *input)
         return 0;
 }

-static inline uint32_t convert_10k_to_mhz(uint32_t clock)
-{
-       return (clock + 99) / 100;
-}
-
 static int smu10_set_min_deep_sleep_dcefclk(struct pp_hwmgr *hwmgr, uint32_t 
clock)
 {
         struct smu10_hwmgr *smu10_data = (struct smu10_hwmgr 
*)(hwmgr->backend);

         if (smu10_data->need_min_deep_sleep_dcefclk &&
-               smu10_data->deep_sleep_dcefclk != convert_10k_to_mhz(clock)) {
-               smu10_data->deep_sleep_dcefclk = convert_10k_to_mhz(clock);
+               smu10_data->deep_sleep_dcefclk != clock) {
+               smu10_data->deep_sleep_dcefclk = clock;
                 smum_send_msg_to_smc_with_parameter(hwmgr,
                                         PPSMC_MSG_SetMinDeepSleepDcefclk,
                                         smu10_data->deep_sleep_dcefclk);
@@ -228,8 +223,8 @@ static int smu10_set_hard_min_dcefclk_by_freq(struct 
pp_hwmgr *hwmgr, uint32_t c
         struct smu10_hwmgr *smu10_data = (struct smu10_hwmgr 
*)(hwmgr->backend);

         if (smu10_data->dcf_actual_hard_min_freq &&
-               smu10_data->dcf_actual_hard_min_freq != 
convert_10k_to_mhz(clock)) {
-               smu10_data->dcf_actual_hard_min_freq = 
convert_10k_to_mhz(clock);
+               smu10_data->dcf_actual_hard_min_freq != clock) {
+               smu10_data->dcf_actual_hard_min_freq = clock;
                 smum_send_msg_to_smc_with_parameter(hwmgr,
                                         PPSMC_MSG_SetHardMinDcefclkByFreq,
                                         smu10_data->dcf_actual_hard_min_freq);
@@ -242,8 +237,8 @@ static int smu10_set_hard_min_fclk_by_freq(struct pp_hwmgr 
*hwmgr, uint32_t cloc
         struct smu10_hwmgr *smu10_data = (struct smu10_hwmgr 
*)(hwmgr->backend);

         if (smu10_data->f_actual_hard_min_freq &&
-               smu10_data->f_actual_hard_min_freq != 
convert_10k_to_mhz(clock)) {
-               smu10_data->f_actual_hard_min_freq = convert_10k_to_mhz(clock);
+               smu10_data->f_actual_hard_min_freq != clock) {
+               smu10_data->f_actual_hard_min_freq = clock;
                 smum_send_msg_to_smc_with_parameter(hwmgr,
                                         PPSMC_MSG_SetHardMinFclkByFreq,
                                         smu10_data->f_actual_hard_min_freq);
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to