better to use div64_ul(x, y) for compatiblity. ________________________________ From: Abramov, Slava Sent: Friday, May 17, 2019 5:19:54 AM To: amd-gfx@lists.freedesktop.org Cc: Pan, Xinhui; Deucher, Alexander Subject: [PATCH] drm/amdgpu: cast to unsigned int for 32-bit portability
Without casting, 64-bit division is used implicitly causing DEPMOD failure when building 32-bit kernel. Signed-off-by: Slava Abramov <slava.abra...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index da1dc40b9b14..0499620ec972 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -764,8 +764,9 @@ static ssize_t amdgpu_ras_sysfs_badpages_read(struct file *f, struct amdgpu_device *adev = con->adev; const unsigned int element_size = sizeof("0xabcdabcd : 0x12345678 : R\n") - 1; - unsigned int start = (ppos + element_size - 1) / element_size; - unsigned int end = (ppos + count - 1) / element_size; + unsigned int start = + (unsigned int) (ppos + element_size - 1) / element_size; + unsigned int end = (unsigned int) (ppos + count - 1) / element_size; ssize_t s = 0; struct ras_badpage *bps = NULL; unsigned int bps_count = 0; -- 2.17.1
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx