On 2019-05-31 1:28 p.m., Yang, Philip wrote: > > On 2019-05-30 6:36 p.m., Kuehling, Felix wrote: >>> >>> #if IS_ENABLED(CONFIG_DRM_AMDGPU_USERPTR) >>> - if (gtt->ranges && >>> - ttm->pages[0] == hmm_pfn_to_page(>t->ranges[0], >>> - gtt->ranges[0].pfns[0])) >>> + if (gtt->range && >>> + ttm->pages[0] == hmm_device_entry_to_page(gtt->range, >>> + gtt->range->pfns[0])) >> I think just checking gtt->range here is enough. If gtt->range is not >> NULL here, we're leaking memory. >> > If just checking gtt->range, there is a false warning in amdgpu_test > userptr case in amdgpu_cs_list_validate path. If userptr is invalidated, > then ttm->pages[0] is outdated pages, lobj->user_pages is new pages, it > goes to ttm_tt_unbind first to unpin old pages (this causes false > warning) then call amdgpu_ttm_tt_set_user_pages.
But doesn't that mean we're leaking the gtt->range somewhere? Regards, Felix > > I will submit patch v2, to add retry if hmm_range_fault returns -EAGAIN. > use kzalloc to allocate small size range. > > Thanks, > Philip > >> Regards, >> Felix >> >> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
