Thanks review . Initial thoughts use this patch for overall initializing the UMD_PSATET_* assignment and some Pstate definitions are not used for patch#2. But combine those two patches also seems well.
Thanks, Prike From: Wang, Kevin(Yang) <kevin1.w...@amd.com> Sent: Wednesday, September 4, 2019 2:32 PM To: Liang, Prike <prike.li...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander <alexander.deuc...@amd.com> Subject: Re: [PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters i think it's better to merge these two patches into one patch. after fixed: Reviewed-by: Kevin Wang <kevin1.w...@amd.com<mailto:kevin1.w...@amd.com>> Best Regards, Kevin ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Liang, Prike <prike.li...@amd.com<mailto:prike.li...@amd.com>> Sent: Wednesday, September 4, 2019 2:01 PM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>> Cc: Deucher, Alexander <alexander.deuc...@amd.com<mailto:alexander.deuc...@amd.com>>; Liang, Prike <prike.li...@amd.com<mailto:prike.li...@amd.com>> Subject: [PATCH 1/2] drm/amd/powerplay: Add UMD PState Renoir Msg Parameters Add UMD PState macro definition for PState update. Signed-off-by: Prike Liang <prike.li...@amd.com<mailto:prike.li...@amd.com>> reviewed-by: Evan Quan <evan.q...@amd.com<mailto:evan.q...@amd.com>> [Kevin]: change "reviewed-by" to "Reviewed-by" --- drivers/gpu/drm/amd/powerplay/renoir_ppt.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.h b/drivers/gpu/drm/amd/powerplay/renoir_ppt.h index e9b7237..a017a47 100644 --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.h +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.h @@ -25,4 +25,9 @@ extern void renoir_set_ppt_funcs(struct smu_context *smu); +//UMD PState Renoir Msg Parameters in MHz +#define RENOIR_UMD_PSTATE_GFXCLK 700 +#define RENOIR_UMD_PSTATE_SOCCLK 678 +#define RENOIR_UMD_PSTATE_FCLK 800 + #endif -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
