On 10/1/19 16:46, Liu, Leo wrote:
>>>> + ring->sched.ready = true;
>>> This is redundant. all the sched->ready is initialized as true, please
>>> refer to drm_sched_init()
>>>
>> I see... so in the following commit 1b61de45dfaf ("drm/amdgpu: add initial
>> VCN2.0 support (v2)")
>> that line is also redundant?
>
> Yes.
>
OK.
>
>>>> r = amdgpu_ring_test_ring(ring);
>>>> if (r) {
>>>> ring->sched.ready = false;
>>>> @@ -266,8 +267,7 @@ static int vcn_v2_5_hw_init(void *handle)
>>>>
>>>> for (i = 0; i < adev->vcn.num_enc_rings; ++i) {
>>>> ring = &adev->vcn.inst[j].ring_enc[i];
>>>> - ring->sched.ready = false;
>>>> - continue;
>>>> + ring->sched.ready = true;
>>> Because the VCN 2.5 FW still has issue for encode, so we have it
>>> disabled here.
>>>
>> OK. So, maybe we can add a comment pointing that out?
>
> That could be better.
>
Great. I'm glad it's not a bug. I'll write a patch for that so other
people don't waste time taking a look.
I appreciate your feedback.
Thanks
--
Gustavo
