Acked-by: Alex Deucher <alexander.deuc...@amd.com> ________________________________ From: Yuan, Xiaojie <xiaojie.y...@amd.com> Sent: Friday, October 11, 2019 4:20 AM To: Deucher, Alexander <alexander.deuc...@amd.com>; Feng, Kenneth <kenneth.f...@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Xiao, Jack <jack.x...@amd.com>; Wang, Kevin(Yang) <kevin1.w...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>; Quan, Evan <evan.q...@amd.com> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit
Hi there, Could someone give an RB or ACK? This patch has been verified on both navi12 and navi14. Thanks. BR, Xiaojie ________________________________ From: Deucher, Alexander <alexander.deuc...@amd.com> Sent: Thursday, October 10, 2019 8:20 PM To: Feng, Kenneth <kenneth.f...@amd.com>; Yuan, Xiaojie <xiaojie.y...@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Xiao, Jack <jack.x...@amd.com>; Wang, Kevin(Yang) <kevin1.w...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>; Quan, Evan <evan.q...@amd.com> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Great. thanks! Alex ________________________________ From: Feng, Kenneth <kenneth.f...@amd.com> Sent: Thursday, October 10, 2019 3:00 AM To: Yuan, Xiaojie <xiaojie.y...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Xiao, Jack <jack.x...@amd.com>; Wang, Kevin(Yang) <kevin1.w...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>; Quan, Evan <evan.q...@amd.com> Subject: RE: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, This issue was navi10 specific and was found in May, 2019. It was early after the asic back, then since gfxoff was removed from navi10, we didn’t really verify which firmware version started to have a fix. For navi14/navi12, there’s no such issue at all. Sorry for losing the track of it. From: Yuan, Xiaojie Sent: Thursday, October 10, 2019 1:17 AM To: Deucher, Alexander <alexander.deuc...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Xiao, Jack <jack.x...@amd.com>; Wang, Kevin(Yang) <kevin1.w...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>; Quan, Evan <evan.q...@amd.com>; Feng, Kenneth <kenneth.f...@amd.com> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit Hi Alex, For now, gfxoff for navi10 is disabled by default, and I also verified on navi14 with both GFXOFF and FW_DSTATE feature bits toggled on. Hi Kenneth / Jack, Could you help to confirm the firmware version? BR, Xiaojie ________________________________ From: Deucher, Alexander <alexander.deuc...@amd.com<mailto:alexander.deuc...@amd.com>> Sent: Wednesday, October 9, 2019 9:35 PM To: Yuan, Xiaojie <xiaojie.y...@amd.com<mailto:xiaojie.y...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack <jack.x...@amd.com<mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) <kevin1.w...@amd.com<mailto:kevin1.w...@amd.com>>; Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>; Quan, Evan <evan.q...@amd.com<mailto:evan.q...@amd.com>>; Feng, Kenneth <kenneth.f...@amd.com<mailto:kenneth.f...@amd.com>> Subject: Re: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit What version of firmware has the fix? Was it recently fixed? We should check the version if the old one may be out in the wild. Alex ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Yuan, Xiaojie <xiaojie.y...@amd.com<mailto:xiaojie.y...@amd.com>> Sent: Wednesday, October 9, 2019 7:08 AM To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>> Cc: Xiao, Jack <jack.x...@amd.com<mailto:jack.x...@amd.com>>; Wang, Kevin(Yang) <kevin1.w...@amd.com<mailto:kevin1.w...@amd.com>>; Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>; Quan, Evan <evan.q...@amd.com<mailto:evan.q...@amd.com>>; Feng, Kenneth <kenneth.f...@amd.com<mailto:kenneth.f...@amd.com>>; Yuan, Xiaojie <xiaojie.y...@amd.com<mailto:xiaojie.y...@amd.com>> Subject: [PATCH 2/2] drm/amd/powerplay: re-enable FW_DSTATE feature bit SMU firmware has fix the bug, so remove this workaround. Signed-off-by: Xiaojie Yuan <xiaojie.y...@amd.com<mailto:xiaojie.y...@amd.com>> --- drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c index 44152c1f01c7..3628295469c4 100644 --- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c @@ -359,11 +359,8 @@ navi10_get_allowed_feature_mask(struct smu_context *smu, | FEATURE_MASK(FEATURE_MEM_VDDCI_SCALING_BIT) | FEATURE_MASK(FEATURE_MEM_MVDD_SCALING_BIT); - if (adev->pm.pp_feature & PP_GFXOFF_MASK) { + if (adev->pm.pp_feature & PP_GFXOFF_MASK) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_GFXOFF_BIT); - /* TODO: remove it once fw fix the bug */ - *(uint64_t *)feature_mask &= ~FEATURE_MASK(FEATURE_FW_DSTATE_BIT); - } if (smu->adev->pg_flags & AMD_PG_SUPPORT_MMHUB) *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_MMHUB_PG_BIT); -- 2.20.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
