On Thu, Oct 10, 2019 at 08:45:25PM -0500, Alex Deucher wrote: > To better match what we are checking for and to align with > amdgpu_device_supports_baco. > > BACO - Bus Active, Chip Off > BOCO - Bus Off, Chip Off
It would be useful to spell out BACO in the preceding patches as well. > - * amdgpu_device_is_px - Is the device is a dGPU with HG/PX power control > + * amdgpu_device_supports_boco - Is the device is a dGPU with HG/PX power > control Duplicate verb. My personal style to document boolean return values is "whether ...", i.e. "whether device is a dGPU with HG/PX power control". But that's just me. _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
