[AMD Official Use Only - Internal Distribution Only] Looks good. The series is: Reviewed-by: Guchun Chen <[email protected]>
Regards, Guchun From: Clements, John <[email protected]> Sent: Thursday, December 26, 2019 10:45 AM To: Chen, Guchun <[email protected]>; [email protected]; Zhang, Hawking <[email protected]> Subject: RE: [PATCH] Series to re-organize and amalgamate certain PSP TA functions [AMD Official Use Only - Internal Distribution Only] Hello Guchun, Thank you for your feedback, I have updated the indentations to make them consistent. I am not so sure if the psp_ta_invoke function should be a static function. As the Linux TA count grows, we may want to split up amdgpu_psp.c to leverage the psp_ta_invoke function from other TA dedicated source file. Thank you, John Clements From: Chen, Guchun <[email protected]<mailto:[email protected]>> Sent: Wednesday, December 25, 2019 9:17 AM To: Clements, John <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Zhang, Hawking <[email protected]<mailto:[email protected]>> Subject: RE: [PATCH] Series to re-organize and amalgamate certain PSP TA functions [AMD Official Use Only - Internal Distribution Only] In patch 3, 1. psp_ta_invoke should be one static function? 2. The indentation in each "return" line looks not correct. With above fixed, series is: Reviewed-by: Guchun Chen <[email protected]<mailto:[email protected]>>. From: amd-gfx <[email protected]<mailto:[email protected]>> On Behalf Of Clements, John Sent: Tuesday, December 24, 2019 11:33 PM To: [email protected]<mailto:[email protected]>; Zhang, Hawking <[email protected]<mailto:[email protected]>> Subject: [PATCH] Series to re-organize and amalgamate certain PSP TA functions [AMD Official Use Only - Internal Distribution Only] Patch 1: * Update PSP command submission to output failure to dmesg by default * Removed masking of response status (as requested by PSP team) Patch 2: * Unify TA function to prepare load/unload commands Patch 3: * Unify TA function to invoke commands Thank you, John Clements
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
