[AMD Public Use]
+#define UMC_REG_OFFSET(adev, ch_inst, umc_inst) ((adev)->umc.channel_offs *
(ch_inst) + UMC_6_INST_DIST*(umc_inst))
Coding style problem, miss blank space around last "*".
+ for (umc_inst = 0; umc_inst < adev->umc.umc_inst_num; umc_inst++)
+ {
Another coding style problem. "{" should follow closely at the same line, not
starting at one new line.
Thirdly, in umc_v6_1_query_ras_error_count, we use dual loops for query error
counter for all UMC channels. But we always use the same variable to do the
query. So the value will be overwritten by new one? Then we will miss former
error counters if there are. Correct?
Regards,
Guchun
From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Zhang,
Hawking
Sent: Thursday, January 2, 2020 8:38 PM
To: Clements, John <john.cleme...@amd.com>; amd-gfx@lists.freedesktop.org;
Zhou1, Tao <tao.zh...@amd.com>
Subject: RE: [PATCH] drm/amdgpu: resolved bug in UMC 6 error counter query
[AMD Official Use Only - Internal Distribution Only]
UMC_REG_OFFSET(adev, ch_inst, umc_inst) and the function get_umc_reg_offset
actually do the same thing? I guess you just want to keep either of them, right?
Regards,
Hawking
From: Clements, John <john.cleme...@amd.com<mailto:john.cleme...@amd.com>>
Sent: Thursday, January 2, 2020 18:31
To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; Zhang,
Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>; Zhou1, Tao
<tao.zh...@amd.com<mailto:tao.zh...@amd.com>>
Subject: [PATCH] drm/amdgpu: resolved bug in UMC 6 error counter query
[AMD Official Use Only - Internal Distribution Only]
Added patch to resolve following issue where error counter detection was not
iterating over all UMC instances/channels.
Removed support for accessing UMC error counters via MMIO.
Thank you,
John Clements
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
