On 1/31/2020 11:21 PM, Zeng, Oak wrote:
[AMD Official Use Only - Internal Distribution Only]

Patch 1,2,3 work for me. See one comment inline, otherwise Reviewed-by: Oak Zeng 
<[email protected]>

Regards,
Oak


Thanks for the review and testing! My response below.

----8< -------------snip ------------------------>8-----------

-void kgd2kfd_suspend(struct kfd_dev *kfd)
+void kgd2kfd_suspend(struct kfd_dev *kfd, bool run_pm)
[Oak] I think parameter run_pm is better to called: call_from_pm_runtime. Or 
you can add some comments to the parameter of this function to say when 
run_pm==true it is called from pm_runtime.


The main purpose of passing this arg is to skip locking kfd for runtime suspend and its already described in the comment above the block that skips locking.

Thanks,

Rajneesh

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to