[AMD Official Use Only - Internal Distribution Only]
Hold on please.
I don't think this is the best approach as we already had existing debugfs
interface for that purpose. We shall centralize all the firmware information
query under amdgpu_debugfs_firmware_info, and user should go through debugfs to
query firmware information.
Regards,
Hawking
-----Original Message-----
From: Liu, Zhan <zhan....@amd.com>
Sent: Tuesday, February 25, 2020 04:55
To: Lakha, Bhawanpreet <bhawanpreet.la...@amd.com>;
amd-gfx@lists.freedesktop.org; Deucher, Alexander <alexander.deuc...@amd.com>;
Zhang, Hawking <hawking.zh...@amd.com>
Cc: Lakha, Bhawanpreet <bhawanpreet.la...@amd.com>
Subject: RE: [PATCH] drm/amdgpu: log TA versions on init
> -----Original Message-----
> From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of
> Bhawanpreet Lakha
> Sent: 2020/February/24, Monday 2:45 PM
> To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> <alexander.deuc...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>
> Cc: Lakha, Bhawanpreet <bhawanpreet.la...@amd.com>
> Subject: [PATCH] drm/amdgpu: log TA versions on init
>
> It is helpful to know what version the TA's are for debugging
>
> Signed-off-by: Bhawanpreet Lakha <bhawanpreet.la...@amd.com>
Reviewed-by: Zhan Liu <zhan....@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index a16c8101e250..09d1433677a6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -358,6 +358,7 @@ static int psp_asd_load(struct psp_context *psp)
> if (!ret) {
> psp->asd_context.asd_initialized = true;
> psp->asd_context.session_id = cmd->resp.session_id;
> + DRM_INFO("ASD: Initialized (version: 0x%X)", psp-
> >asd_fw_version);
> }
>
> kfree(cmd);
> @@ -518,6 +519,7 @@ static int psp_xgmi_load(struct psp_context *psp)
> if (!ret) {
> psp->xgmi_context.initialized = 1;
> psp->xgmi_context.session_id = cmd->resp.session_id;
> + DRM_INFO("XGMI: Initialized (version: 0x%X)", psp-
> >ta_xgmi_ucode_version);
> }
>
> kfree(cmd);
> @@ -658,6 +660,7 @@ static int psp_ras_load(struct psp_context *psp)
> if (!ret) {
> psp->ras.ras_initialized = true;
> psp->ras.session_id = cmd->resp.session_id;
> + DRM_INFO("RAS: Initialized (version: 0x%X)", psp-
> >ta_ras_ucode_version);
> }
>
> kfree(cmd);
> @@ -832,6 +835,7 @@ static int psp_hdcp_load(struct psp_context *psp)
> if (!ret) {
> psp->hdcp_context.hdcp_initialized = true;
> psp->hdcp_context.session_id = cmd->resp.session_id;
> + DRM_INFO("HDCP: Initialized (version: 0x%X)", psp-
> >ta_hdcp_ucode_version);
> }
>
> kfree(cmd);
> @@ -977,6 +981,7 @@ static int psp_dtm_load(struct psp_context *psp)
> if (!ret) {
> psp->dtm_context.dtm_initialized = true;
> psp->dtm_context.session_id = cmd->resp.session_id;
> + DRM_INFO("DTM: Initialized (version: 0x%X)", psp-
> >ta_dtm_ucode_version);
> }
>
> kfree(cmd);
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
