[AMD Public Use] case CHIP_ARCTURUS: + return __get_eeprom_i2c_addr_arct(adev, i2c_addr); + break;
This 'break' is not needed. Please remove it. Regards, Guchun From: amd-gfx <[email protected]> On Behalf Of Zhang, Hawking Sent: Tuesday, February 25, 2020 6:42 PM To: Clements, John <[email protected]>; [email protected] Subject: RE: [PATCH] drm/amdgpu: Add Arcturus D342 page retire support [AMD Official Use Only - Internal Distribution Only] Please fix your coding style in the follow if/else code segment by removing the unnecessary {}. Other than that, the patch is Reviewed-by: Hawking Zhang <[email protected]<mailto:[email protected]>> + if (strnstr(atom_ctx->vbios_version, + "D342", + sizeof(atom_ctx->vbios_version))) + { + *i2c_addr = EEPROM_I2C_TARGET_ADDR_ARCTURUS_D342; + } + else + { + *i2c_addr = EEPROM_I2C_TARGET_ADDR_ARCTURUS; + } Regards, Hawking From: Clements, John <[email protected]<mailto:[email protected]>> Sent: Tuesday, February 25, 2020 17:58 To: [email protected]<mailto:[email protected]>; Zhang, Hawking <[email protected]<mailto:[email protected]>> Subject: [PATCH] drm/amdgpu: Add Arcturus D342 page retire support Add support for detecting Arcturus SKU to resolve the correct bad page retirement EEPROM I2C address. Thank you, John Clements
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
