[AMD Official Use Only - Internal Distribution Only] My bad, please ignore this. I re-sent this in a separate one patch.
Alejandro S -----Original Message----- From: Kuehling, Felix <[email protected]> Sent: Friday, March 20, 2020 9:37 AM To: Sierra Guiza, Alejandro (Alex) <[email protected]>; [email protected] Subject: Re: [PATCH 1/6] drm/amdgpu: ih doorbell size of range changed for nbio v7.4 On 2020-03-19 20:24, Alex Sierra wrote: > [Why] > nbio v7.4 size of ih doorbell range is 64 bit. This requires 2 DWords per > register. > > [How] > Change ih doorbell size from 2 to 4. This means two Dwords per ring. > Current configuration uses two ih rings. > > Signed-off-by: Alex Sierra <[email protected]> Why is the subject "PATCH 1/6"? It makes me wonder, what are the other 5 patches. Anyway, this patch is Reviewed-by: Felix Kuehling <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c > b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c > index 149d386590df..263dbb1f92ee 100644 > --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c > +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c > @@ -185,7 +185,7 @@ static void nbio_v7_4_ih_doorbell_range(struct > amdgpu_device *adev, > > if (use_doorbell) { > ih_doorbell_range = REG_SET_FIELD(ih_doorbell_range, > BIF_IH_DOORBELL_RANGE, OFFSET, doorbell_index); > - ih_doorbell_range = REG_SET_FIELD(ih_doorbell_range, > BIF_IH_DOORBELL_RANGE, SIZE, 2); > + ih_doorbell_range = REG_SET_FIELD(ih_doorbell_range, > +BIF_IH_DOORBELL_RANGE, SIZE, 4); > } else > ih_doorbell_range = REG_SET_FIELD(ih_doorbell_range, > BIF_IH_DOORBELL_RANGE, SIZE, 0); > _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
