It's Ok to have the valid_in_vf setting as 1 for now. As I know the sriov support for sienna_cichlid is not ready now. We can revise these when that comes.
Reviewed-by: Evan Quan <[email protected]> BR, Evan -----Original Message----- From: Sheng, Wenhui <[email protected]> Sent: Tuesday, July 21, 2020 4:09 PM To: Gao, Likun <[email protected]>; [email protected] Cc: Zhang, Hawking <[email protected]>; Quan, Evan <[email protected]> Subject: RE: [PATCH] drm/amd/powerplay: add msg map for mode1 reset [AMD Official Use Only - Internal Distribution Only] Commit : 81a5f33903a30574 has already contains this change, not sure why it disappear in current branch. And does it make sense to set valid_in_vf to be true? Mode1 reset shouldn't be supported in vf mode I think. Brs Wenhui -----Original Message----- From: Gao, Likun <[email protected]> Sent: Tuesday, July 21, 2020 1:21 PM To: [email protected] Cc: Zhang, Hawking <[email protected]>; Sheng, Wenhui <[email protected]>; Quan, Evan <[email protected]>; Gao, Likun <[email protected]> Subject: [PATCH] drm/amd/powerplay: add msg map for mode1 reset From: Likun Gao <[email protected]> Mapping Mode1Reset message for sienna_cichlid. Signed-off-by: Likun Gao <[email protected]> Change-Id: I9b8d39b10c7723af4589577fdbfa4acd5af6e85d --- drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c index cae8e776fafe..bf3d6bbba930 100644 --- a/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c +++ b/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c @@ -118,6 +118,7 @@ static struct cmn2asic_msg_mapping sienna_cichlid_message_map[SMU_MSG_MAX_COUNT] MSG_MAP(PowerDownJpeg, PPSMC_MSG_PowerDownJpeg, 1), MSG_MAP(BacoAudioD3PME, PPSMC_MSG_BacoAudioD3PME, 1), MSG_MAP(ArmD3, PPSMC_MSG_ArmD3, 1), + MSG_MAP(Mode1Reset, PPSMC_MSG_Mode1Reset, 1), }; static struct cmn2asic_mapping sienna_cichlid_clk_map[SMU_CLK_COUNT] = { -- 2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
