[AMD Public Use]
Also, general nit, per kernel coding style, braces should be on the same line
as the if or else, E.g.,
} else {
Alex
________________________________
From: amd-gfx <[email protected]> on behalf of Zhang,
Hawking <[email protected]>
Sent: Friday, September 11, 2020 2:02 AM
To: Clements, John <[email protected]>; amd-gfx list
<[email protected]>; Chen, Guchun <[email protected]>
Subject: RE: [PATCH] drm/amdgpu: Update RAS init handling
[AMD Public Use]
+ {
+ dev_warn(psp->adev->dev, "RAS
Init Status: 0x%X\n", ras_cmd->ras_status);
+ }
Please remove the redundant bracket.
Other than that, the patch is
Reviewed-by: Hawking Zhang <[email protected]>
In addition, please create another patch to move the nbio ras controller irq
source registry to sw_init, which is the consistent as what we did for other ip
blocks, register the irq source in IP sw_init funcs.
Regards,
Hawking
From: Clements, John <[email protected]>
Sent: Friday, September 11, 2020 12:03
To: amd-gfx list <[email protected]>; Chen, Guchun
<[email protected]>; Zhang, Hawking <[email protected]>
Subject: [PATCH] drm/amdgpu: Update RAS init handling
[AMD Official Use Only - Internal Distribution Only]
Added RAS status check and tear down RAS context if RAS init fails
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
