smc fw is not needed in SRIOV, thus driver should not try to get smc
fw data.

Signed-off-by: Jingwen Chen <jingwen.ch...@amd.com>
---
 .../gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c    | 61 ++++++++++---------
 1 file changed, 32 insertions(+), 29 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
index b53872eb4398..d8ca6d968813 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0.c
@@ -322,39 +322,42 @@ int smu_v11_0_setup_pptable(struct smu_context *smu)
        void *table;
        uint16_t version_major, version_minor;
 
-       hdr = (const struct smc_firmware_header_v1_0 *) adev->pm.fw->data;
-       version_major = le16_to_cpu(hdr->header.header_version_major);
-       version_minor = le16_to_cpu(hdr->header.header_version_minor);
-       if ((version_major == 2 && smu->smu_table.boot_values.pp_table_id > 0) 
||
-           adev->asic_type == CHIP_NAVY_FLOUNDER) {
-               dev_info(adev->dev, "use driver provided pptable %d\n", 
smu->smu_table.boot_values.pp_table_id);
-               switch (version_minor) {
-               case 0:
-                       ret = smu_v11_0_set_pptable_v2_0(smu, &table, &size);
-                       break;
-               case 1:
-                       ret = smu_v11_0_set_pptable_v2_1(smu, &table, &size,
-                                                        
smu->smu_table.boot_values.pp_table_id);
-                       break;
-               default:
-                       ret = -EINVAL;
-                       break;
+       if (!amdgpu_sriov_vf(adev)) {
+               hdr = (const struct smc_firmware_header_v1_0 *) 
adev->pm.fw->data;
+               version_major = le16_to_cpu(hdr->header.header_version_major);
+               version_minor = le16_to_cpu(hdr->header.header_version_minor);
+               if ((version_major == 2 && 
smu->smu_table.boot_values.pp_table_id > 0) ||
+                       adev->asic_type == CHIP_NAVY_FLOUNDER) {
+                       dev_info(adev->dev, "use driver provided pptable %d\n", 
smu->smu_table.boot_values.pp_table_id);
+                       switch (version_minor) {
+                       case 0:
+                               ret = smu_v11_0_set_pptable_v2_0(smu, &table, 
&size);
+                               break;
+                       case 1:
+                               ret = smu_v11_0_set_pptable_v2_1(smu, &table, 
&size,
+                                                               
smu->smu_table.boot_values.pp_table_id);
+                               break;
+                       default:
+                               ret = -EINVAL;
+                               break;
+                       }
+                       if (ret)
+                               return ret;
+                       goto out;
                }
-               if (ret)
-                       return ret;
+       }
 
-       } else {
-               dev_info(adev->dev, "use vbios provided pptable\n");
-               index = 
get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
-                                                   powerplayinfo);
+       dev_info(adev->dev, "use vbios provided pptable\n");
+       index = 
get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
+                                               powerplayinfo);
 
-               ret = amdgpu_atombios_get_data_table(adev, index, 
&atom_table_size, &frev, &crev,
-                                             (uint8_t **)&table);
-               if (ret)
-                       return ret;
-               size = atom_table_size;
-       }
+       ret = amdgpu_atombios_get_data_table(adev, index, &atom_table_size, 
&frev, &crev,
+                                               (uint8_t **)&table);
+       if (ret)
+               return ret;
+       size = atom_table_size;
 
+out:
        if (!smu->smu_table.power_play_table)
                smu->smu_table.power_play_table = table;
        if (!smu->smu_table.power_play_table_size)
-- 
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reply via email to