Acked-by: Nirmoy Das <[email protected]>
On 9/25/20 4:31 PM, Alex Deucher wrote:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value
of ‘sysfs_create_group’, declared with attribute warn_unused_result
[-Wunused-result]
1284 | sysfs_create_group(&adev->dev->kobj, &group);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Alex Deucher <[email protected]>
---
Do we care whether this fails or not?
I think we should. Failure in sysfs_create_group() means memory starved
system or we are doing something in the driver code.
IMO in both cases, we should error out.
Nirmoy
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 49d10330bf64..67724049a0fc 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -1281,9 +1281,7 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
sysfs_bin_attr_init(bin_attrs[0]);
}
- sysfs_create_group(&adev->dev->kobj, &group);
-
- return 0;
+ return sysfs_create_group(&adev->dev->kobj, &group);
}
static int amdgpu_ras_fs_fini(struct amdgpu_device *adev)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
