[AMD Public Use] Thanks for your reminder, I'll add another patch to enable gpu recovery.
Tao From: Deucher, Alexander <alexander.deuc...@amd.com> Sent: Tuesday, December 15, 2020 10:27 PM To: Chen, Jiansong (Simon) <jiansong.c...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>; Gui, Jack <jack....@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish [AMD Official Use Only - Internal Distribution Only] You will also need to add the asic_type to amdgpu_device_should_recover_gpu() if you the driver to actually use GPU reset when it encounters a hang. Alex ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org<mailto:amd-gfx-boun...@lists.freedesktop.org>> on behalf of Chen, Jiansong (Simon) <jiansong.c...@amd.com<mailto:jiansong.c...@amd.com>> Sent: Tuesday, December 15, 2020 5:33 AM To: Zhou1, Tao <tao.zh...@amd.com<mailto:tao.zh...@amd.com>>; Gui, Jack <jack....@amd.com<mailto:jack....@amd.com>>; Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>> Subject: RE: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish [AMD Official Use Only - Internal Distribution Only] [AMD Official Use Only - Internal Distribution Only] Reviewed-by: Jiansong Chen <jiansong.c...@amd.com<mailto:jiansong.c...@amd.com>> -----Original Message----- From: Zhou1, Tao <tao.zh...@amd.com<mailto:tao.zh...@amd.com>> Sent: Tuesday, December 15, 2020 6:23 PM To: Chen, Jiansong (Simon) <jiansong.c...@amd.com<mailto:jiansong.c...@amd.com>>; Gui, Jack <jack....@amd.com<mailto:jack....@amd.com>>; Zhang, Hawking <hawking.zh...@amd.com<mailto:hawking.zh...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Cc: Zhou1, Tao <tao.zh...@amd.com<mailto:tao.zh...@amd.com>> Subject: [PATCH] drm/amdgpu: set mode1 reset as default for dimgrey_cavefish Use mode1 reset for dimgrey_cavefish by default. Signed-off-by: Tao Zhou <tao.zh...@amd.com<mailto:tao.zh...@amd.com>> --- drivers/gpu/drm/amd/amdgpu/nv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c index ac02dd707c44..6bee3677394a 100644 --- a/drivers/gpu/drm/amd/amdgpu/nv.c +++ b/drivers/gpu/drm/amd/amdgpu/nv.c @@ -362,6 +362,7 @@ nv_asic_reset_method(struct amdgpu_device *adev) switch (adev->asic_type) { case CHIP_SIENNA_CICHLID: case CHIP_NAVY_FLOUNDER: +case CHIP_DIMGREY_CAVEFISH: return AMD_RESET_METHOD_MODE1; default: if (smu_baco_is_support(smu)) -- 2.17.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7Cb3da8467a171425a6cf208d8a0e4d612%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637436252010819826%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=fr8uXVyoVz5WlYtYPRbKm1%2BN0ROBWuLuqPOuL3%2BHC0E%3D&reserved=0
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
