Your v2 has my Reviewed-by: Mario Kleiner <[email protected]>
thanks, -mario On Wed, Feb 17, 2021 at 11:51 PM Alex Deucher <[email protected]> wrote: > From: Mario Kleiner <[email protected]> > > Spatial dithering to 10 bpc depth was disabled for all DCE's. > > Testing on DCE-8.3 and DCE-11.2 did not show any obvious ill > effects, but a measureable precision improvement (via colorimeter) > when displaying a fp16 framebuffer to a 10 bpc DP or HDMI connected > HDR-10 monitor. > > v2: enable it for all DCEs (Alex) > > Signed-off-by: Mario Kleiner <[email protected]> > Cc: Alex Deucher <[email protected]> > Signed-off-by: Alex Deucher <[email protected]> > --- > drivers/gpu/drm/amd/display/dc/dce/dce_opp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c > b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c > index 4600231da6cb..895b015b02e8 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_opp.c > @@ -216,9 +216,7 @@ static void set_spatial_dither( > REG_UPDATE(FMT_BIT_DEPTH_CONTROL, > FMT_TEMPORAL_DITHER_EN, 0); > > - /* no 10bpc on DCE11*/ > - if (params->flags.SPATIAL_DITHER_ENABLED == 0 || > - params->flags.SPATIAL_DITHER_DEPTH == 2) > + if (params->flags.SPATIAL_DITHER_ENABLED == 0) > return; > > /* only use FRAME_COUNTER_MAX if frameRandom == 1*/ > -- > 2.29.2 > >
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
