[AMD Official Use Only - Internal Distribution Only] Hi All, Thanks for the inputs, have updated the patch to include these changes.
Regards, Bindu ________________________________ From: Lakha, Bhawanpreet <bhawanpreet.la...@amd.com> Sent: Wednesday, March 17, 2021 1:02 PM To: Michel Dänzer <mic...@daenzer.net>; R, Bindu <bind...@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Feng, Kenneth <kenneth.f...@amd.com>; Zhou1, Tao <tao.zh...@amd.com> Subject: Re: [PATCH] drm/amd/display: Allow idle optimization based on vblank. [AMD Official Use Only - Internal Distribution Only] Hi Bindu, dc_allow_idle_optimizations() should be called within mutex_lock(&dm->dc_lock). Please call it right after WARN_ON(!dc_commit_state(dm->dc, dc_state)) but before unlock(). Bhawan ________________________________ From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> on behalf of Michel Dänzer <mic...@daenzer.net> Sent: March 17, 2021 7:37 AM To: R, Bindu <bind...@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org> Cc: Deucher, Alexander <alexander.deuc...@amd.com>; Feng, Kenneth <kenneth.f...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>; Lakha, Bhawanpreet <bhawanpreet.la...@amd.com> Subject: Re: [PATCH] drm/amd/display: Allow idle optimization based on vblank. On 2021-03-17 12:49 a.m., Bindu Ramamurthy wrote: > [Why] > idle optimization was being disabled after commit. > > [How] > check vblank count for display off and enable idle optimization based on this > count. > > Signed-off-by: Bindu Ramamurthy <bind...@amd.com> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 553e39f9538c..56a55143ad2d 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -987,7 +987,7 @@ static void event_mall_stutter(struct work_struct *work) > > if (vblank_work->enable) > dm->active_vblank_irq_count++; > - else > + else if(dm->active_vblank_irq_count) > dm->active_vblank_irq_count--; The commit log should explain why this part is needed. -- Earthling Michel Dänzer | https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fredhat.com%2F&data=04%7C01%7Cbhawanpreet.lakha%40amd.com%7C11fd0779679742148e2a08d8e938fe34%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637515778296313590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2BPsyjDxRCTdR9HL1QSlCraWo7YpFg%2FJT8i%2BSsG%2BQvZE%3D&reserved=0 Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cbhawanpreet.lakha%40amd.com%7C11fd0779679742148e2a08d8e938fe34%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637515778296313590%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=L4fr6qPeO5rcMi0zg9bk9xLRTKtyVRTJ3LcSPd3Qlyw%3D&reserved=0
_______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
