On 2021-04-29 10:50 p.m., Bas Nieuwenhuizen wrote: > This reverts commit f258907fdd835e1aed6d666b00cdd0f186676b7c. > > Same problem as "drm/amdgpu: Verify bo size can fit framebuffer size", > but because it gets checked earlier it now only triggers on the > modifiers case. > > There are a couple of reasons why the DRM core BO size check won't > work for AMDGPU, especially around DCC planes. > > Signed-off-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl> > --- > > For -fixes. Might have some conflicts with > "drm/amdgpu: Ensure that the modifier requested is supported by plane" > for amd-staging-drm-next
This interacts badly with 79fcd446e7e1 "drm/amdgpu: Fix memory leak", resulting in BOs getting destroyed prematurely and ensuing badness. To avoid that, at least the drm_gem_object_put call needs to be removed from the end of amdgpu_display_user_framebuffer_create needs to be removed as well, if not 79fcd446e7e1 reverted altogether. I suspect 79fcd446e7e1 was at least partly a fix-up for f258907fdd83, to compensate for drm_gem_fb_init_with_funcs incrementing the BO reference counts. -- Earthling Michel Dänzer | https://redhat.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
