You could even write why it was disabled before and why you can enable it now again in the commit message.
Regards //Ernst Den tis 11 maj 2021 kl 09:25 skrev Chen, Jiansong (Simon) < [email protected]>: > [AMD Official Use Only - Internal Distribution Only] > > Better to make the commit msg more specific, eg. Change predicate > accordingly since aspm is enabled by default. > Either way, Reviewed-by: Jiansong Chen <[email protected]> > > Regards, > Jiansong > -----Original Message----- > From: amd-gfx <[email protected]> On Behalf Of > Kenneth Feng > Sent: Tuesday, May 11, 2021 11:04 AM > To: [email protected] > Cc: Feng, Kenneth <[email protected]> > Subject: [PATCH] drm/amd/pm: enable ASPM by default > > enable ASPM by default > > Signed-off-by: Kenneth Feng <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/nv.c | 2 +- > drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +- > drivers/gpu/drm/amd/amdgpu/vi.c | 2 +- > drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c > b/drivers/gpu/drm/amd/amdgpu/nv.c index 82a380be8368..2fcfd893edc5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/nv.c > +++ b/drivers/gpu/drm/amd/amdgpu/nv.c > @@ -598,7 +598,7 @@ static void nv_pcie_gen3_enable(struct amdgpu_device > *adev) > > static void nv_program_aspm(struct amdgpu_device *adev) { > - if (amdgpu_aspm != 1) > + if (!amdgpu_aspm) > return; > > if (!(adev->flags & AMD_IS_APU) && > diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c > b/drivers/gpu/drm/amd/amdgpu/soc15.c > index 49ece2a7f9f0..4b660b2d1c22 100644 > --- a/drivers/gpu/drm/amd/amdgpu/soc15.c > +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c > @@ -817,7 +817,7 @@ static void soc15_pcie_gen3_enable(struct > amdgpu_device *adev) > > static void soc15_program_aspm(struct amdgpu_device *adev) { > - if (amdgpu_aspm != 1) > + if (!amdgpu_aspm) > return; > > if (!(adev->flags & AMD_IS_APU) && > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c > b/drivers/gpu/drm/amd/amdgpu/vi.c index 735ebbd1148f..3d21c0799037 100644 > --- a/drivers/gpu/drm/amd/amdgpu/vi.c > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c > @@ -1136,7 +1136,7 @@ static void vi_program_aspm(struct amdgpu_device > *adev) > bool bL1SS = false; > bool bClkReqSupport = true; > > - if (amdgpu_aspm != 1) > + if (!amdgpu_aspm) > return; > > if (adev->flags & AMD_IS_APU || > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c > b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c > index d2fd44b903ca..270b2b0b8e8a 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c > @@ -302,7 +302,7 @@ sienna_cichlid_get_allowed_feature_mask(struct > smu_context *smu, > if (smu->dc_controlled_by_gpio) > *(uint64_t *)feature_mask |= FEATURE_MASK(FEATURE_ACDC_BIT); > > - if (amdgpu_aspm == 1) > + if (amdgpu_aspm) > *(uint64_t *)feature_mask |= > FEATURE_MASK(FEATURE_DS_LCLK_BIT); > > return 0; > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > [email protected] > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CJiansong.Chen%40amd.com%7C414e894d646e4161c7ab08d914296d92%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637562990432397285%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=TvVZdWM32y8rOn154m%2B0pLvHxk9fEuOaiBqiIxXSxiE%3D&reserved=0 > _______________________________________________ > amd-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/amd-gfx >
_______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
