RE: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs

[Limonciello, Mario]

[Public]

smu_get_power_profile_mode actually calls smu->ppt_funcs->get_power_profile_mode

So shouldn't it be sufficient to do this?

        } else if (DEVICE_ATTR_IS(pp_power_profile_mode)) {
                if (!adev->smu.ppt_funcs->get_power_profile_mode)
                        *states = ATTR_STATE_UNSUPPORTED;
        }


From: Lazar, Lijo <lijo.la...@amd.com>
Sent: Saturday, October 30, 2021 10:06
To: Alex Deucher <alexdeuc...@gmail.com>
Cc: Limonciello, Mario <mario.limoncie...@amd.com>; 
amd-gfx@lists.freedesktop.org; Deucher, Alexander <alexander.deuc...@amd.com>
Subject: Re: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and 
later APUs


[Public]

For swsmu, we could add a helper macro like smu_is_supported(x) that checks if 
ppt func is not NULL.

Thanks,
Lijo