On 2021-11-10 10:26, Alex Deucher wrote: > Disable vblanks immediately to save power. I think this was > missed when we merged DC support. > > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1781 > Signed-off-by: Alex Deucher <[email protected]>
Reviewed-by: Harry Wentland <[email protected]> Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 - > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > index cc2e0c9cfe0a..4f3c62adccbd 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c > @@ -333,7 +333,6 @@ int amdgpu_irq_init(struct amdgpu_device *adev) > if (!amdgpu_device_has_dc_support(adev)) { > if (!adev->enable_virtual_display) > /* Disable vblank IRQs aggressively for power-saving */ > - /* XXX: can this be enabled for DC? */ > adev_to_drm(adev)->vblank_disable_immediate = true; > > r = drm_vblank_init(adev_to_drm(adev), > adev->mode_info.num_crtc); > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index 1371432c8f11..652c973e6daa 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -1590,6 +1590,9 @@ static int amdgpu_dm_init(struct amdgpu_device *adev) > adev_to_drm(adev)->mode_config.cursor_width = > adev->dm.dc->caps.max_cursor_size; > adev_to_drm(adev)->mode_config.cursor_height = > adev->dm.dc->caps.max_cursor_size; > > + /* Disable vblank IRQs aggressively for power-saving */ > + adev_to_drm(adev)->vblank_disable_immediate = true; > + > if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) { > DRM_ERROR( > "amdgpu: failed to initialize sw for display support.\n"); >
