[Public] Series is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> ________________________________ From: Chen, Guchun <guchun.c...@amd.com> Sent: Friday, January 14, 2022 12:58 AM To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian <christian.koe...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>; Zhou, Peng Ju <pengju.z...@amd.com> Cc: Chen, Guchun <guchun.c...@amd.com> Subject: [PATCH 1/2] drm/amdgpu: drop redundant check of ip discovery_bin
Early check in amdgpu_discovery_reg_base_init promises this. Signed-off-by: Guchun Chen <guchun.c...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c index 57e001d73ec9..2f891ae90bad 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c @@ -1194,11 +1194,6 @@ int amdgpu_discovery_set_ip_blocks(struct amdgpu_device *adev) return -EINVAL; amdgpu_discovery_harvest_ip(adev); - - if (!adev->mman.discovery_bin) { - DRM_ERROR("ip discovery uninitialized\n"); - return -EINVAL; - } break; } -- 2.17.1