[AMD Official Use Only]
Thank you very much Alex!
Regards,
Rico
________________________________
From: Alex Deucher <alexdeuc...@gmail.com>
Sent: Friday, March 11, 2022 0:52
To: Yin, Tianci (Rico) <tianci....@amd.com>
Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; Chen, Guchun
<guchun.c...@amd.com>; Zhuo, Qingqing (Lillian) <qingqing.z...@amd.com>; Liu,
Wenjing <wenjing....@amd.com>; Wang, Yu (Charlie) <yu.wa...@amd.com>; Deucher,
Alexander <alexander.deuc...@amd.com>; Quan, Evan <evan.q...@amd.com>
Subject: Re: [PATCH] drm/amd: fix gfx hang on renoir in IGT reload test
On Thu, Mar 10, 2022 at 9:04 AM Tianci Yin <tianci....@amd.com> wrote:
>
> From: "Tianci.Yin" <tianci....@amd.com>
>
> [why]
> CP hangs in igt reloading test on renoir, more precisely, hangs on the
> second time insmod.
>
> [how]
> mode2 reset can make it recover, and mode2 reset only effects gfx core,
> dcn and the screen will not be impacted.
>
> Signed-off-by: Tianci.Yin <tianci....@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/soc15.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
> b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 496c4a6e23ac..f0713c027ed5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -853,6 +853,11 @@ static bool soc15_need_reset_on_init(struct
> amdgpu_device *adev)
> {
> u32 sol_reg;
>
> + /* CP hangs in IGT reloading test on RN, reset to WA */
> + if(adev->asic_type == CHIP_RENOIR) {
Space between if and (. Also, you can drop the { }. With that fixed:
Acked-by: Alex Deucher <alexander.deuc...@amd.com>
Alex
> + return true;
> + }
> +
> /* Just return false for soc15 GPUs. Reset does not seem to
> * be necessary.
> */
> --
> 2.25.1
>
