[AMD Official Use Only] Thank you James!
Rico ________________________________ From: Zhu, James <[email protected]> Sent: Sunday, March 27, 2022 21:47 To: Yin, Tianci (Rico) <[email protected]>; [email protected] <[email protected]> Cc: Chen, Guchun <[email protected]>; Wang, Yu (Charlie) <[email protected]> Subject: Re: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0 [AMD Official Use Only] This patch is Reviewed-by: James Zhu <[email protected]> ________________________________ From: Tianci Yin <[email protected]> Sent: Sunday, March 27, 2022 7:18 AM To: [email protected] <[email protected]> Cc: Chen, Guchun <[email protected]>; Zhu, James <[email protected]>; Wang, Yu (Charlie) <[email protected]>; Yin, Tianci (Rico) <[email protected]> Subject: [PATCH] drm/amd/vcn: fix an error msg on vcn 3.0 From: tiancyin <[email protected]> Some video card has more than one vcn instance, passing 0 to vcn_v3_0_pause_dpg_mode is incorrect. Error msg: Register(1) [mmUVD_POWER_STATUS] failed to reach value 0x00000001 != 0x00000002 Signed-off-by: tiancyin <[email protected]> --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c index e1cca0a10653..cb5f0a12333f 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c @@ -1488,7 +1488,7 @@ static int vcn_v3_0_stop_dpg_mode(struct amdgpu_device *adev, int inst_idx) struct dpg_pause_state state = {.fw_based = VCN_DPG_STATE__UNPAUSE}; uint32_t tmp; - vcn_v3_0_pause_dpg_mode(adev, 0, &state); + vcn_v3_0_pause_dpg_mode(adev, inst_idx, &state); /* Wait for power status to be 1 */ SOC15_WAIT_ON_RREG(VCN, inst_idx, mmUVD_POWER_STATUS, 1, -- 2.25.1
