[AMD Official Use Only - General]

Hi Rodrigo,

Sorry, my bad! Thanks for the fix, but only adjust the indentation will miss 
another code path for amdgpu_ras_block_late_init.
Let me submit a new one to fix it.



Thanks,
Candice

-----Original Message-----
From: Siqueira, Rodrigo <[email protected]> 
Sent: Wednesday, June 1, 2022 10:14 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Li, Candice 
<[email protected]>; Zhang, Hawking <[email protected]>
Subject: [PATCH] drm/amdgpu: Correct if identation that causes GCC warning

GCC is complaining about misleading indentation:

error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
  603 |  if (r)

This commit adjusts the commit indentation.

Cc: Candice Li <[email protected]>
Cc: Hawking Zhang <[email protected]>

Signed-off-by: Rodrigo Siqueira <[email protected]>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c 
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
index 99c1a2d3dae8..e1f4c5f30645 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
@@ -599,9 +599,9 @@ int amdgpu_gfx_ras_late_init(struct amdgpu_device *adev, 
struct ras_common_if *r
                if (!amdgpu_persistent_edc_harvesting_supported(adev))
                        amdgpu_ras_reset_error_status(adev, 
AMDGPU_RAS_BLOCK__GFX);
 
-       r = amdgpu_ras_block_late_init(adev, ras_block);
-       if (r)
-               return r;
+               r = amdgpu_ras_block_late_init(adev, ras_block);
+               if (r)
+                       return r;
 
                r = amdgpu_irq_get(adev, &adev->gfx.cp_ecc_error_irq, 0);
                if (r)
-- 
2.25.1

Reply via email to