Re: [PATCH] drm/amdkfd: Remove field io_link_count from struct kfd_topology_device

[Felix Kuehling]

On 2022-06-08 07:51, Ramesh Errabolu wrote:

The field is redundant and does not serve any functional role

Signed-off-by: Ramesh Errabolu <ramesh.errab...@amd.com>

Reviewed-by: Felix Kuehling <felix.kuehl...@amd.com>

---
  drivers/gpu/drm/amd/amdkfd/kfd_crat.c     | 2 --
  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 1 -
  drivers/gpu/drm/amd/amdkfd/kfd_topology.h | 1 -
  3 files changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index cbfb32b3d235..a5409531a2fd 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -1040,7 +1040,6 @@ static int kfd_parse_subtype_iolink(struct 
crat_subtype_iolink *iolink,
                        props->rec_transfer_size =
                                        iolink->recommended_transfer_size;

- dev->io_link_count++;

                        dev->node_props.io_links_count++;
                        list_add_tail(&props->list, &dev->io_link_props);
                        break;
@@ -1067,7 +1066,6 @@ static int kfd_parse_subtype_iolink(struct 
crat_subtype_iolink *iolink,
                props2->node_from = id_to;
                props2->node_to = id_from;
                props2->kobj = NULL;
-               to_dev->io_link_count++;
                to_dev->node_props.io_links_count++;
                list_add_tail(&props2->list, &to_dev->io_link_props);
        }
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
index 3e240b22ec91..304322ac39e6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
@@ -1819,7 +1819,6 @@ static void kfd_topology_update_io_links(int 
proximity_domain)
                         */
                        if (iolink->node_to == proximity_domain) {
                                list_del(&iolink->list);
-                               dev->io_link_count--;
                                dev->node_props.io_links_count--;
                        } else {
                                if (iolink->node_from > proximity_domain)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h 
b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
index 2fb5664e1041..9f6c949186c1 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.h
@@ -130,7 +130,6 @@ struct kfd_topology_device {
        struct list_head                mem_props;
        uint32_t                        cache_count;
        struct list_head                cache_props;
-       uint32_t                        io_link_count;
        struct list_head                io_link_props;
        struct list_head                p2p_link_props;
        struct list_head                perf_props;